OkHttp3 instrumentation with observation api #3176

marcingrzejszczak · 2022-05-13T14:53:28Z

No description provided.

sonatype-lift · 2022-05-13T15:11:34Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

@@ -102,19 +84,24 @@ private static Method getMethod(Class<?>... parameterTypes) {

    private final boolean includeHostTag;

+    private final boolean observationRegistryNoOp;


UnusedVariable: The field 'observationRegistryNoOp' is never read.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-13T15:11:41Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+                okHttpContext.setResponse(new HttpClientResponse() {
+                    @Override
+                    public int statusCode() {
+                        return state.response.code();


NULL_DEREFERENCE: object OkHttpMetricsEventListener$2.val$state.response last accessed on line 214 could be null and is dereferenced at line 214.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-13T15:11:43Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+        if (callState.request != null) {
+            okHttpContext.setRequest(new HttpClientRequest() {
+
+                Set<KeyValue> headers = StreamSupport.stream(callState.request.headers().spliterator(), false)


NULL_DEREFERENCE: object OkHttpMetricsEventListener$1.val$callState.request last accessed on line 129 could be null and is dereferenced at line 129.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-13T15:11:44Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+
+                    @Override
+                    public Collection<String> headerNames() {
+                        return state.response.headers().names();


NULL_DEREFERENCE: object OkHttpMetricsEventListener$2.val$state.response last accessed on line 219 could be null and is dereferenced at line 219.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-13T15:11:48Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+
+                @Override
+                public String method() {
+                    return callState.request.method();


NULL_DEREFERENCE: object OkHttpMetricsEventListener$1.val$callState.request last accessed on line 140 could be null and is dereferenced at line 140.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-13T15:11:51Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+
+                @Override
+                public String url() {
+                    return callState.request.url().toString();


NULL_DEREFERENCE: object OkHttpMetricsEventListener$1.val$callState.request last accessed on line 150 could be null and is dereferenced at line 150.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-13T15:11:54Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+
+                @Override
+                public String path() {
+                    return callState.request.url().pathSegments().get(0);


NULL_DEREFERENCE: object OkHttpMetricsEventListener$1.val$callState.request last accessed on line 145 could be null and is dereferenced at line 145.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-16T12:55:54Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

@@ -102,19 +84,24 @@ private static Method getMethod(Class<?>... parameterTypes) {

    private final boolean includeHostTag;

+    private final boolean observationRegistryNoOp;


UnusedVariable: The field 'observationRegistryNoOp' is never read.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-16T12:56:44Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+                okHttpContext.setResponse(new HttpClientResponse() {
+                    @Override
+                    public int statusCode() {
+                        return state.response.code();


NULL_DEREFERENCE: object OkHttpMetricsEventListener$3.val$state.response last accessed on line 219 could be null and is dereferenced at line 219.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-16T12:56:45Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+
+                @Override
+                public String method() {
+                    return callState.request.method();


NULL_DEREFERENCE: object OkHttpMetricsEventListener$2.val$callState.request last accessed on line 145 could be null and is dereferenced at line 145.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-16T12:56:47Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+
+                @Override
+                public String url() {
+                    return callState.request.url().toString();


NULL_DEREFERENCE: object OkHttpMetricsEventListener$2.val$callState.request last accessed on line 155 could be null and is dereferenced at line 155.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-16T12:56:53Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+
+                    @Override
+                    public Collection<String> headerNames() {
+                        return state.response.headers().names();


NULL_DEREFERENCE: object OkHttpMetricsEventListener$3.val$state.response last accessed on line 224 could be null and is dereferenced at line 224.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-16T12:56:57Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+
+                @Override
+                public String path() {
+                    return callState.request.url().pathSegments().get(0);


NULL_DEREFERENCE: object OkHttpMetricsEventListener$2.val$callState.request last accessed on line 150 could be null and is dereferenced at line 150.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-16T12:56:59Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+        if (callState.request != null) {
+            okHttpContext.setRequest(new HttpClientRequest() {
+
+                Set<KeyValue> headers = StreamSupport.stream(callState.request.headers().spliterator(), false)


NULL_DEREFERENCE: object OkHttpMetricsEventListener$2.val$callState.request last accessed on line 134 could be null and is dereferenced at line 134.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-18T13:18:07Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     * Examples:
+     * CERN-LineMode/2.15 libwww/2.17b3
+     *
+     * @param request


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param request

*

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-18T13:18:11Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     * 200
+     *
+     * @param response
+     * @return


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @return

*

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-18T13:18:15Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     * Examples:
+     * /path/12314/?q=ddds#123
+     *
+     * @param request


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param request

*

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-18T13:18:18Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     * 80; 8080; 443
+     *
+     * @param request
+     * @return


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @return

*

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-18T13:18:23Z

...c/main/java/io/micrometer/observation/transport/http/tags/HttpServerKeyValuesConvention.java

+     * /users/:userID?
+     *
+     * @param request
+     * @return


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @return

*

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-18T13:18:29Z

...c/main/java/io/micrometer/observation/transport/http/tags/HttpServerKeyValuesConvention.java

+     * Examples:
+     * /users/:userID?
+     *
+     * @param request


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param request

*

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-18T13:18:34Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     * 1.0
+     *
+     * @param request
+     * @return


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @return

*

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-18T13:18:36Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     *
+     * @param request
+     * @param response
+     * @return


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @return

*

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-18T13:18:37Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     * Sets all key values.
+     *
+     * @param request
+     * @param response


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param response

*

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-18T13:18:40Z

...c/main/java/io/micrometer/observation/transport/http/tags/HttpServerKeyValuesConvention.java

+     * /users/5
+     *
+     * @param request
+     * @return


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @return

*

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-18T13:18:41Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     * Examples:
+     * 200
+     *
+     * @param response


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param response

*

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-18T13:18:47Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     * Examples:
+     * GET; POST; HEAD
+     *
+     * @param request


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param request

*

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-18T13:18:51Z

...c/main/java/io/micrometer/observation/transport/http/tags/HttpServerKeyValuesConvention.java

+     * Examples:
+     * /users/5
+     *
+     * @param request


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param request

*

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-18T13:18:53Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     * /path/12314/?q=ddds#123
+     *
+     * @param request
+     * @return


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @return

*

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-05-18T13:18:57Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     * Examples:
+     * https://www.foo.bar/search?q=OpenTelemetry#SemConv
+     *
+     * @param request


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param request

*

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:15Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     * The URI scheme identifying the used protocol.
+     *
+     * Examples: http; https
+     * @param request


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param request

*

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:16Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     * The full request target as passed in a HTTP request line or equivalent.
+     *
+     * Examples: /path/12314/?q=ddds#123
+     * @param request


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param request

*

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:19Z

...c/main/java/io/micrometer/observation/transport/http/tags/HttpServerKeyValuesConvention.java

+     * X-Forwarded-For).
+     *
+     * Examples: 83.164.160.102
+     * @param request


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param request

*

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:21Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     * compressed size.
+     *
+     * Examples: 3495
+     * @param request


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param request

*

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:22Z

micrometer-observation/src/main/java/io/micrometer/observation/ObservationRegistry.java

+         * @param clazz {@link Observation.KeyValuesConvention} class
+         * @param <T> type of convention
+         * @return registered convention
+         * @throws {@link IllegalStateException} when no


UnrecognisedJavadocTag: This Javadoc tag wasn't recognised by the parser. Is it malformed somehow, perhaps with mismatched braces?

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:24Z

...c/main/java/io/micrometer/observation/transport/http/tags/HttpServerKeyValuesConvention.java

+     * set ( net.host.name should be used instead).
+     *
+     * Examples: example.com
+     * @param request


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param request

*

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:25Z

...c/main/java/io/micrometer/observation/transport/http/tags/HttpServerKeyValuesConvention.java

+     *
+     * Examples: /users/:userID?
+     * @param request
+     * @return


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @return

*

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:26Z

...c/main/java/io/micrometer/observation/transport/http/tags/HttpClientKeyValuesConvention.java

+     * Examples: example.com
+     *
+     * SHOULD NOT be set if capturing it would require an extra DNS lookup.
+     * @param request


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param request

*

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:28Z

micrometer-observation/src/main/java/io/micrometer/observation/ObservationRegistry.java

+         * @param clazz {@link Observation.KeyValuesConvention} class
+         * @param <T> type of convention
+         * @return registered convention
+         * @throws {@link IllegalStateException} when no


InvalidThrowsLink: Javadoc links to exceptions in @throws without a @link tag (@throws Exception, not @throws {@link Exception}).

Suggested change

* @throws {@link IllegalStateException} when no

* @throws IllegalStateException when no

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:29Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+    /**
+     * Sets all key values.
+     * @param request
+     * @param response


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param response

*

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:30Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+                okHttpContext.setResponse(new HttpClientResponse() {
+                    @Override
+                    public int statusCode() {
+                        return state.response.code();


NULL_DEREFERENCE: object OkHttpMetricsEventListener$2.val$state.response last accessed on line 217 could be null and is dereferenced at line 217.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:32Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+
+                @Override
+                public String method() {
+                    return callState.request.method();


NULL_DEREFERENCE: object OkHttpMetricsEventListener$1.val$callState.request last accessed on line 145 could be null and is dereferenced at line 145.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:33Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+        if (callState.request != null) {
+            okHttpContext.setRequest(new HttpClientRequest() {
+
+                Set<KeyValue> headers = StreamSupport.stream(callState.request.headers().spliterator(), false)


NULL_DEREFERENCE: object OkHttpMetricsEventListener$1.val$callState.request last accessed on line 134 could be null and is dereferenced at line 134.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:34Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     *
+     * Examples: 127.0.0.1
+     * @param request
+     * @return


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @return

*

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:35Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     *
+     * Examples: 3495
+     * @param request
+     * @return


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @return

*

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:36Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     *
+     * Examples: 200
+     * @param response
+     * @return


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @return

*

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:38Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     * included nevertheless.
+     *
+     * Examples: https://www.foo.bar/search?q=OpenTelemetry#SemConv
+     * @param request


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param request

*

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:39Z

...ion/src/main/java/io/micrometer/observation/transport/http/tags/HttpKeyValuesConvention.java

+     *
+     * Examples: 3495
+     * @param response
+     * @return


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @return

*

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T11:15:41Z

...c/main/java/io/micrometer/observation/transport/http/tags/HttpServerKeyValuesConvention.java

+     *
+     * Examples: /users/5
+     * @param request
+     * @return


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @return

*

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

- removed the service locator like solution in ObservationRegistry for naming conventions. Users will have to provide a convention manually (or in frameworks like Boot it will happen for them) - added noop impls for conventions since we have no-null apis

sonatype-lift · 2022-06-17T12:00:03Z

micrometer-commons/src/main/java/io/micrometer/common/ValidatedKeyValue.java

+/**
+ * {@link KeyValue} with value validation.
+ *
+ * @param <T>


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @param <T>

*

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T12:00:05Z

micrometer-observation/src/main/java/io/micrometer/observation/ObservationRegistry.java

@@ -98,6 +101,13 @@ class ObservationConfig {

        private final List<Observation.GlobalKeyValuesProvider<?>> keyValuesProviders = new CopyOnWriteArrayList<>();

+        private final List<ObservationFilter> observationFilters = new CopyOnWriteArrayList<>();
+
+        private final Map<Class<? extends Observation.KeyValuesConvention>, Observation.KeyValuesConvention> keyValuesConventions = new ConcurrentHashMap<>();


UnusedVariable: The field 'keyValuesConventions' is never read.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T12:00:07Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+
+                @Override
+                public String path() {
+                    return callState.request.url().pathSegments().get(0);


NULL_DEREFERENCE: object OkHttpMetricsEventListener$1.val$callState.request last accessed on line 154 could be null and is dereferenced at line 154.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T12:00:08Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+
+                    @Override
+                    public Collection<String> headerNames() {
+                        return state.response.headers().names();


NULL_DEREFERENCE: object OkHttpMetricsEventListener$2.val$state.response last accessed on line 226 could be null and is dereferenced at line 226.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T12:00:09Z

...e/src/main/java/io/micrometer/core/instrument/binder/okhttp3/OkHttpMetricsEventListener.java

+
+                @Override
+                public String url() {
+                    return callState.request.url().toString();


NULL_DEREFERENCE: object OkHttpMetricsEventListener$1.val$callState.request last accessed on line 159 could be null and is dereferenced at line 159.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift bot reviewed May 13, 2022

View reviewed changes

sonatype-lift bot reviewed May 16, 2022

View reviewed changes

marcingrzejszczak force-pushed the okhttp3_observation branch from 7a4478f to 248af9f Compare May 18, 2022 13:03

sonatype-lift bot reviewed May 18, 2022

View reviewed changes

sonatype-lift bot reviewed Jun 17, 2022

View reviewed changes

marcingrzejszczak added 2 commits June 17, 2022 13:45

Polishing

5177ef5

- removed the service locator like solution in ObservationRegistry for naming conventions. Users will have to provide a convention manually (or in frameworks like Boot it will happen for them) - added noop impls for conventions since we have no-null apis

Fixed formatting

f95468d

marcingrzejszczak added the enhancement A general enhancement label Jun 17, 2022

marcingrzejszczak added this to the 1.10.0-M3 milestone Jun 17, 2022

sonatype-lift bot reviewed Jun 17, 2022

View reviewed changes

marcingrzejszczak merged commit 15a98f9 into main Jun 17, 2022

jonatan-ivanov deleted the okhttp3_observation branch June 18, 2022 01:29

		@@ -102,19 +84,24 @@ private static Method getMethod(Class<?>... parameterTypes) {

		private final boolean includeHostTag;

		private final boolean observationRegistryNoOp;

	* @throws {@link IllegalStateException} when no
	* @throws IllegalStateException when no

OkHttp3 instrumentation with observation api #3176

OkHttp3 instrumentation with observation api #3176

Uh oh!

Conversation

marcingrzejszczak commented May 13, 2022

Uh oh!

sonatype-lift bot May 13, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 13, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 13, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 13, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 13, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 13, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 13, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 16, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 16, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 16, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 16, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 16, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 16, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 16, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 18, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 18, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 18, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 18, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 18, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 18, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 18, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 18, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 18, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 18, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot May 18, 2022

Choose a reason for hiding this comment