Introduce HttpTagsProvider with default implementation #2945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to provide a consistent default set of HTTP tags derived from the abstract request/response API that instrumentation will wrap using their concrete HTTP request/response objects.
It also allows end users (not instrumentors) to provide their own implementation if they want a different set of tags without rewriting the instrumentation provided.
TODO:
It's unfortunate it shares the name and purpose of the
TagsProvider
interface but does not extend it because it has parameters specific to it. Perhaps this is something to consider evolving in a more clear way later on.Example usage of this in instrumentation is like the following. Pass an
HttpTagsProvider
instance to theHttpHandlerContext
being used with yourTimer.start
calls. For convenience, a constructor withoutHttpTagsProvider
is available that will use the default implementation.