Provide support for Hazelcast 4 (with compatibility to Hazelcast 3) #1952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leszko
force-pushed
the
hazelcast-4-compatible-3
branch
from
0c9943c to
4af8293
Compare
Closed
|
Thanks for this. It'd be best if we have a sample project with Hazelcast 3 and a sample project with Hazelcast 4 that gets built and tests run on each to ensure we don't break anything going forward. They could go in the |
|
@shakuzen Good, I'll add it to this PR. |
leszko
force-pushed
the
hazelcast-4-compatible-3
branch
from
08b6926 to
59a2f3b
Compare
|
Added two sample projects: 'hazelcast', 'hazelcast-3-compatibility'. @shakuzen, could you please check? |
Signed-off-by: Rafal Leszko <[email protected]>
Signed-off-by: Rafal Leszko <[email protected]>
Signed-off-by: Rafal Leszko <[email protected]>
shakuzen
force-pushed
the
hazelcast-4-compatible-3
branch
from
59a2f3b to
bc2425e
Compare
snicoll
reviewed
Apr 27, 2020
...ter-core/src/main/java/io/micrometer/core/instrument/binder/cache/HazelcastCacheMetrics.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1697
Alternative to #1868, uses reflection to keep the compatibility to Hazelcast 3