Skip to content

Move to new Humio structered API. #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2019
Merged

Move to new Humio structered API. #1544

merged 2 commits into from
Sep 29, 2019

Conversation

mwl
Copy link
Contributor

@mwl mwl commented Aug 15, 2019 •
edited by shakuzen
Loading

New structured API doesn't require a repo reference so was removed as well.

References

@mwl
Copy link
Contributor Author

mwl commented Aug 15, 2019

CI checks currently failing due to apparently unrelated Atlas issue. Please advice

@shakuzen shakuzen mentioned this pull request Aug 16, 2019
Closed
@shakuzen
Copy link
Member

@mwl I've opened #1545 regarding the build failure.

@shakuzen
Copy link
Member

@mwl if you rebase this branch on master, it should have the previous build issue resolved.

@mwl mwl force-pushed the master branch 2 times, most recently from ee9e890 to 71853b0 Compare August 22, 2019 07:50
@mwl
Copy link
Contributor Author

mwl commented Aug 22, 2019

Tested against upcoming Humio 1.6.0 but should also be compatible with everything from 1.2 onwards

@mwl mwl marked this pull request as ready for review August 22, 2019 08:31
@mwl
Copy link
Contributor Author

mwl commented Aug 22, 2019

Documentation might need updating too. What's the process for that?

@shakuzen
Copy link
Member

Documentation might need updating too. What's the process for that?

Documentation is at https://github.com/micrometer-metrics/micrometer-docs/
Feel free to send a pull request over there with doc updates. Thanks.

shakuzen
shakuzen reviewed Aug 27, 2019
View reviewed changes
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request. I am not very familiar with Humio, so I just want to understand how the change might affect users. For example, I want to ensure that after this change, any existing dashboards and queries will continue to work.

@shakuzen shakuzen added registry: humio A Humio Registry related issue enhancement A general enhancement labels Aug 27, 2019
@shakuzen shakuzen added this to the 1.3.0 milestone Aug 27, 2019
@mwl
Copy link
Contributor Author

mwl commented Aug 27, 2019

@shakuzen I for one (as an Humio employee) do not want to break any dashboards etc. either, so I'm very carefull when I make these changes and by the end of the day these changes are just reflecting what is actually going on in the server where dataspace/repository is being ignored and resolved from the ingest token.
The API used in current version of Micrometer has been deprecated some time ago so to make sure Micrometer works as usual going forward we should move to the latest api as soon as possible.
Currently there a re no plans to delete the API in question.

@shakuzen
Copy link
Member

Thank you for the explanation and care taken here. I've assigned this to the 1.3 milestone so we can get this change out in the next feature release.

mwl added 2 commits August 27, 2019 21:20
@mwl
Move to new Humio structered API.
5ad0e41 
New structured API doesn't require a repo reference so was removed as well.
@mwl
Reinstated the repository config method for Humio registry
fea166a
@shakuzen shakuzen added the spring-boot change Change is needed in Spring Boot for this issue label Sep 29, 2019
@shakuzen
Copy link
Member

In our Spring support, we'll want to make sure that the repository property gets marked as deprecated. I've added the spring-boot change label to remind me of this.

@shakuzen shakuzen merged commit 6b13f8c into micrometer-metrics:master Sep 29, 2019
izeye added a commit to izeye/micrometer that referenced this pull request Oct 25, 2019
@izeye
Remove the deprecated HumioConfig.repository()
00b97da 
See micrometer-metrics#1544 (comment)
@izeye izeye mentioned this pull request Oct 25, 2019
Merged
shakuzen pushed a commit that referenced this pull request Oct 28, 2019
@izeye @shakuzen
Remove the deprecated HumioConfig.repository() (#1668)
744467c 
See #1544 (comment)
mwl added a commit to mwl/micrometer-docs that referenced this pull request Jan 14, 2020
@mwl
Updating Humio docs to reflect 1.3 changes
4c75142 
In 1.3 we deprecated the `repository` parameter, see micrometer-metrics/micrometer#1544

Corrected the example query, as it already had an `avg` field. Output is the same as before so no need to update screenshot.
@mwl mwl mentioned this pull request Jan 14, 2020
Merged
shakuzen pushed a commit to micrometer-metrics/micrometer-docs that referenced this pull request Jan 14, 2020
@mwl @shakuzen
Updating Humio docs to reflect 1.3 changes (#116)
f9882b2 
In 1.3 we deprecated the `repository` parameter, see micrometer-metrics/micrometer#1544

Corrected the example query, as it already had an `avg` field. Output is the same as before so no need to update screenshot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakuzen shakuzen shakuzen left review comments

Assignees
No one assigned
Labels
enhancement A general enhancement registry: humio A Humio Registry related issue spring-boot change Change is needed in Spring Boot for this issue
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mwl @shakuzen