Add base units for ForkJoinPool #1525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
reviewed
Jul 22, 2019
There was a problem hiding this comment.
Units can affect the translated metric ID in some backends. Namely, Prometheus will add the units to the metric name. That makes this a breaking change for those users. So we don't want to do this in a patch release, and I'm on the fence about even doing it in a minor release - though it is certainly an omission that we didn't do this in the first place.
shakuzen
added
enhancement
|
Can you rebase this against the |
|
@shakuzen Sure, done. |
jonatan-ivanov
approved these changes
Mar 3, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds base units for
ForkJoinPooland also polishesTimedExecutorServicea bit.