Updating to the latest micrometer changes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhalbritter
reviewed
Jun 30, 2022
| @@ -49,4 +51,13 @@ public KeyValue clientIp(HttpRequest request) { | |||
| return OpenTelemetryHttpServerLowCardinalityKeyNames.CLIENT_IP.of("UNKNOWN"); | |||
There was a problem hiding this comment.
Isn't there something missing? Extracing the client IP from the request?
There was a problem hiding this comment.
Yeah, everything is missing - I've done only the method key value as an example :)
marcingrzejszczak
force-pushed
the
observationConvention
branch
from
795f59d to
c6d7e27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prerequisite - micrometer-metrics/micrometer#3255