Skip to content

Fix: MicrocksClient with GlobalClientOptions is not able to handle insucure TLS request #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lbroudoux merged 1 commit into from
Sep 10, 2025
Merged

Fix: MicrocksClient with GlobalClientOptions is not able to handle insucure TLS request #182

lbroudoux merged 1 commit into from
Sep 10, 2025

Conversation

@Harsh4902
Copy link
Member

@Harsh4902 Harsh4902 commented Aug 7, 2025

Description

  • This PR fixes MicrocksClient, which was not able to handle insecure TLS request previously.

Related issue(s)

Fixes #180

@Harsh4902 Harsh4902 requested a review from lbroudoux as a code owner August 7, 2025 16:45
@github-actions
Copy link

github-actions bot commented Sep 7, 2025

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 30 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. Microcks is a Cloud Native Computing Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale State due to inactivity label Sep 7, 2025
@lbroudoux lbroudoux added kind/bug Something isn't working component/cli and removed stale State due to inactivity labels Sep 8, 2025
@lbroudoux lbroudoux added this to the 1.0.0 milestone Sep 8, 2025
lbroudoux
lbroudoux approved these changes Sep 8, 2025
View reviewed changes
Copy link
Member

@lbroudoux lbroudoux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It embeds commits from previous PR like #160 but seems safe to merge after a rebase. I can't do it with the GitiHub UI: some prerequisites are failing. @Harsh4902 can you do this easily?

@Harsh4902
Copy link
Member Author

Harsh4902 commented Sep 8, 2025

It embeds commits from previous PR like #160 but seems safe to merge after a rebase. I can't do it with the GitiHub UI: some prerequisites are failing. @Harsh4902 can you do this easily?

Okay, I'll take a look.

@Harsh4902 Harsh4902 requested a review from lbroudoux September 8, 2025 10:45
lbroudoux
lbroudoux approved these changes Sep 10, 2025
View reviewed changes
Copy link
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Harsh4902 for the update!

@lbroudoux lbroudoux merged commit 48ac36f into microcks:1.x Sep 10, 2025
4 of 5 checks passed
@lbroudoux lbroudoux mentioned this pull request Sep 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lbroudoux lbroudoux lbroudoux approved these changes

Assignees

No one assigned

Labels

component/cli kind/bug Something isn't working

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Harsh4902 @lbroudoux