Skip to content

Conversation

@Caesarsage
Copy link
Contributor

  • Introduced a new command import-dir to allow users to import multiple API specification files from a specified directory.
  • Implemented functionality to scan for supported file types (.yaml, .yml, .json, .xml) and handle recursive imports.
  • Added unit tests to ensure the reliability of the import process.
  • Updated documentation to include usage examples and details about the new command.

This feature enhances the CLI's capabilities for managing API specifications efficiently.

Related issue(s)

Fixes #171

Addresses: #97 (Support for directory import)

@Caesarsage Caesarsage requested a review from lbroudoux as a code owner July 13, 2025 23:53
- Introduced a new command `import-dir` to allow users to import multiple API specification files from a specified directory.
- Implemented functionality to scan for supported file types (.yaml, .yml, .json, .xml) and handle recursive imports.
- Added comprehensive unit tests to ensure the reliability of the import process.
- Updated documentation to include usage examples and details about the new command.

This feature enhances the CLI's capabilities for managing API specifications efficiently.

Signed-off-by: caesarsage <[email protected]>
@Caesarsage Caesarsage force-pushed the add-import-dir-cli branch from 2b33c13 to 73273e0 Compare July 13, 2025 23:53
@Harsh4902
Copy link
Member

@Caesarsage Thank you so much for this PR. It's actually a very good implementation for import-dir command. I have some concerns:

  • Maybe we can use existing API sspecifications which are already present in /sample/ directory.
  • We are thinking to move all import related commands as sub-command like import url, import dir, so maybe we can integrate this after the migration. It will basically reduce the overhead after the new implementation.

@Caesarsage
Copy link
Contributor Author

Kindly review @lbroudoux @hash

@Caesarsage Thank you so much for this PR. It's actually a very good implementation for import-dir command. I have some concerns:

  • Maybe we can use existing API sspecifications which are already present in /sample/ directory.
  • We are thinking to move all import related commands as sub-command like import url, import dir, so maybe we can integrate this after the migration. It will basically reduce the overhead after the new implementation.

Thank you for the feedback and for reviewing the PR! @Harsh4902
I can update the PR to use only the existing API specifications in the /samples/ directory and remove any extra sample files I added for demonstration/testing.

for the command restructure, I agree it would be more efficient to integrate the import-dir functionality after the import commands are refactored into sub-commands.

Please let me know when the migration is complete, and I’ll be happy to rebase and adapt this PR to fit the new structure.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 30 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. Microcks is a Cloud Native Computing Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale State due to inactivity label Aug 23, 2025
@lbroudoux lbroudoux added keep-open Explicitily keep open and removed stale State due to inactivity labels Sep 8, 2025
@Harsh4902 Harsh4902 mentioned this pull request Oct 9, 2025
Copy link
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience @Caesarsage! This is great work and I'd like to introduce a first version of it in the next 1.0.1 release. I'm going to merge this one in the microcks:1.x branch and then merge it back (and resolve potentiel conflicts in master).

Thanks a lot for this contribution!

@lbroudoux lbroudoux merged commit 30fe104 into microcks:1.x Nov 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants