Skip to content

Conversation

@michealroberts
Copy link
Owner

refactor: amend GeographicCoordinate in common in celerity module

refactor: amend GeographicCoordinate in common in celerity module
@michealroberts michealroberts requested a review from Copilot October 9, 2025 17:57
@michealroberts michealroberts self-assigned this Oct 9, 2025
@michealroberts michealroberts added the enhancement New feature or request label Oct 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the GeographicCoordinate type definition in the celerity module to use more descriptive field names. The changes rename coordinate fields from abbreviated forms (lat, lon, el) to their full descriptive names (latitude, longitude, elevation).

  • Updates the GeographicCoordinate TypedDict definition to use full field names
  • Updates all test files and source modules to use the new field names
  • Maintains backwards compatibility by updating all references consistently

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/celerity/common.py Updates GeographicCoordinate type definition with descriptive field names
src/celerity/coordinates.py Updates coordinate conversion functions to use new field names and reorganizes imports
src/celerity/transit.py Updates transit calculation functions to use new latitude field name
src/celerity/temporal.py Updates time conversion function to use new longitude field name
src/celerity/astrometry.py Updates parallactic angle calculation to use new field names
tests/*.py Updates all test files to use new field names in observer coordinate definitions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@michealroberts michealroberts merged commit af5f625 into main Oct 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants