feat: add perform_definite_integral to integration in celerity module #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michealroberts
added
enhancement
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new function, perform_definite_integral, to the celerity module to approximate definite integrals using Simpson's rule.
- Implements perform_definite_integral with input validations and Simpson’s rule calculations.
- Adds comprehensive unit tests in tests/test_integration.py covering polynomial, trigonometric, exponential functions, along with edge cases.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/celerity/integration.py | Adds perform_definite_integral using Simpson's rule with validation. |
| tests/test_integration.py | Provides unit tests to verify integration with various functions. |
feat: add perform_definite_integral to integration in celerity module
michealroberts
force-pushed
the
feature/integration/perform_definite_integral
branch
from
3fde2f9 to
9fd9719
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new function, perform_definite_integral, to compute the definite integral using Simpson’s rule and includes corresponding tests.
- Added the perform_definite_integral implementation to src/celerity/integration.py
- Included comprehensive tests in tests/test_integration.py to validate various integration scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_integration.py | Introduces tests for the new integration function using a variety of mathematical functions |
| src/celerity/integration.py | Implements perform_definite_integral using Simpson’s rule with proper input validations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add perform_definite_integral to integration in celerity module