Strip query params #222
Merged
Strip query params #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This PR introduce a security issue on the master branch. Please revert the logic and never release the 3.0.0 tag. Exemple : I have a website with : /ressource?id=X With your change a attacker can access with a signature replay attacks with the same signature the page : /ressource?id=Y See this exemple here : https://scs.owasp.org/SCWE/SCSVS-CRYPTO/SCWE-055/ |
Owner
Author
|
Thanks @fwininger — I'll remove this option. |
mgomes
added a commit
that referenced
this pull request
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query params in the request URI can be problematic as pointed out in #123. Since we are going to do a major release soon, this PR introduces a backwards compatible approach to ignoring query params by default.
Fixes #123