Skip to content

Conversation

boesing
Copy link
Member

@boesing boesing commented Aug 27, 2020

No description provided.

Signed-off-by: Maximilian Bösing <[email protected]>
@boesing boesing added the Enhancement New feature or request label Aug 27, 2020
@boesing boesing added this to the 1.0.0 milestone Aug 27, 2020
Copy link
Contributor

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um... we need to test against PHP 8 as well, which means a .travis.yml entry...

@michalbundyra
Copy link
Member

@weierophinney

Um... we need to test against PHP 8 as well, which means a .travis.yml entry...

It's already there:

https://github.com/mezzio/mezzio-cors/blob/1.0.x/.travis.yml#L29-L39

@weierophinney
Copy link
Contributor

It's already there:

My bad! I assumed it wasn't, as this patch was adding the constraint!

Copy link
Contributor

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@weierophinney weierophinney merged commit f335f60 into mezzio:1.0.x Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants