Skip to content

Conversation

boesing
Copy link
Member

@boesing boesing commented Oct 7, 2022

Q A
Bugfix yes

Description

This component was released with an accidentally widened PHP constraint back in August 2020 due to myself introducing PHP 8.0 support.
With PHP 8.1, I also added ~8.1.0 (which was unnecessary at this point, I have no idea why I didn't realized it back then...) as in laminas/mezzio/laminas-api-tools components, we do use more strict PHP constraints to avoid surprises with new PHP releases.

As of now, this component would be installable on PHP 8.2 while it was never tested with that version. Since we do not want to provide implicit support for PHP 8.2, changing the PHP constraint to ~7.4.0 || ~8.0.0 || ~8.1.0 will do the trick.

Closes #45

@boesing boesing added the Bug Something isn't working label Oct 7, 2022
@boesing boesing added this to the 1.4.1 milestone Oct 7, 2022
@boesing boesing linked an issue Oct 7, 2022 that may be closed by this pull request
@boesing boesing requested a review from Ocramius October 7, 2022 14:33
@Ocramius Ocramius self-assigned this Oct 7, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @boesing!

@Ocramius Ocramius merged commit 6c875e9 into mezzio:1.4.x Oct 7, 2022
@boesing boesing deleted the bugfix/php-composer-constraints branch October 7, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Likely wrong PHP version declaration
2 participants