MA0053 takes ctor visibility into account to determine if a class should be sealed

[meziantou]

No description provided.

[Copilot]

Pull Request Overview

The PR enhances rule MA0053 to seal classes only if they can be inherited outside the assembly by checking constructor visibility and adds corresponding tests.

• Adds Theory tests for private, internal, and public/protected constructors in ClassMustBeSealedAnalyzerTests.cs
• Updates IsPotentialSealed to compute canBeInheritedOutsideOfAssembly based on constructor visibilities

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/Meziantou.Analyzer.Test/Rules/ClassMustBeSealedAnalyzerTests.cs	Added tests for classes with varying constructor visibility
src/Meziantou.Analyzer/Rules/ClassMustBeSealedAnalyzer.cs	Refined sealing logic to consider constructor visibility

Comments suppressed due to low confidence (1)

tests/Meziantou.Analyzer.Test/Rules/ClassMustBeSealedAnalyzerTests.cs:283

• [nitpick] The ClassWithPublicCtor test does not assert a diagnostic for a public constructor case. Surround the class name with [| and |] to indicate the expected diagnostic position.

                public class Sample