Parameters provided by `multipart-middleware` are overridden by `coerce-request-middleware`

[ferdinand-beyer]

We use a middleware stack that uses both multipart-middleware and coerce-request-middleware, in that order.

We had the strange behaviour that a route that defines both :parameters :multipart and :parameters :path had :multipart-params in the request, but no :parameters :multipart.

After some digging, it turns out that multipart-middleware merges the coerced params into :parameters, but coerce-request-middleware assocs :parameters, overwriting existing data at that key. In our case: the :multipart part.

It seems like we would need to swap the order, and apply the multipart middleware after the coercion middleware.

Alternatively, we ended up using the plain Ring multipart middleware, and configure our coercion so that coerce-request-middleware also coerces :multipart-params.

This might be a documentation issue, or maybe coerce-request-middleware should also merge?

[opqdonut]

Thanks for bringing this up!

In all of the reitit examples, multipart-middleware comes after coerce-request-middleware, so that should definitely work.

We should at least document this constraint, but also consider relaxing it. A merge sounds like the right way to go, you're right.