Aggregate throws an error when snapshot type is not registered #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since snapshotting can be disabled we will need a bit more refactoring but in a separate PR. |
|
Good improvement, but let's add a test for this |
|
Would be good to roll this into develop ready for the next release |
|
We need to write a test that cover throwing of this error and tests for rest of errors thrown by es aggregate. I will take care of this next week. I am not available before that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have this error now instead of 'undefined is not a function' when snapshot is not registered:
Error: Space.eventSourcing.Aggregate: Snapshot type is undefined. Did you forget to call: Space.eventSourcing.Aggregate.registerSnapshotType()?