Improve warning from scaler when samples are missing #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwa7
approved these changes
Oct 23, 2025
jwa7
requested changes
Nov 6, 2025
Member
jwa7
left a comment
jwa7
left a comment
There was a problem hiding this comment.
After discussion, we can remove the warning as it is not necessary, and replace in the code:
# If any scales are zero or NaN, set them to 1.0
scale_vals_type[scale_vals_type == 0] = 1.0
scale_vals_type[torch.isnan(scale_vals_type)] = 1.0
It would trigger in cases where the data is padded and then masked in the loss.
Luthaf
force-pushed
the
better-scaler-error
branch
from
1560f2d to
6bddb01
Compare
Member
Author
|
cscs-ci run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should reconsider this warning in presence of a mask, because then some of the
Nwill be zero by construction. Let's have a chat before merging!(This also serves as a PR for me to check that codecov from a fork works again)
Contributor (creator of pull-request) checklist
Tests updated (for new features and bugfixes)?Documentation updated (for new features)?Issue referenced (for PRs that solve an issue)?Maintainer/Reviewer checklist
📚 Documentation preview 📚: https://metatrain--856.org.readthedocs.build/en/856/