-
Notifications
You must be signed in to change notification settings - Fork 1
Add FlashMD #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: metatomic
Are you sure you want to change the base?
Add FlashMD #21
Conversation
| double *mass = atom->mass; | ||
| int *type = atom->type; | ||
| int *mask = atom->mask; | ||
| if (igroup == atom->firstgroup) nlocal = atom->nfirst; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if (igroup == atom->firstgroup) nlocal = atom->nfirst; | |
| if (igroup == atom->firstgroup) { | |
| nlocal = atom->nfirst; | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same line is used by all other LAMMPS fixes with the same formatting
| int nghost = atom->nghost; | ||
| int nall = nlocal + nghost; | ||
|
|
||
| double *mass = atom->mass; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference between rmass and mass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LAMMPS allows per-type masses as well as per-atom masses (to support e.g. different isotopes of the same element within the same simulation). rmass contains one mass per atom in the latter case, otherwise it's undefined and you have to use mass[type[i]]
if (atom->rmass)
m = atom->rmass[i]; // per-atom mass array exists
else
m = atom->mass[type[i]]; // fall back to per-type mass
|
@copilot This code integrates a new machine-learning-driven integrator into LAMMPS, through an interface called metatomic. The prototype you see here works well. I have three tasks for you:
|
|
@frostedoyster I've opened a new pull request, #30, to work on those changes. Once the pull request is ready, I'll request review from you. |
Add a new fix that uses a model to predict future positions and momenta.