Skip to content

Conversation

lentzi90
Copy link
Member

This adds a plugin to mdbook for embedding files from any repo on github.
My plan is to use this when refreshing the quick-start guide. To see how it works, check this WIP PR: #585

@metal3-io-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2025
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kashifest for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 16, 2025
Comment on lines -21 to -22
.PHONY: releasetags
releasetags: $(RELEASETAGS)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the phony for releasetags since it seemed unnecessary to me. We were not using it anywhere so the only thing it could be used for is to manually build the binary releasetags.

@lentzi90 lentzi90 marked this pull request as ready for review October 16, 2025 11:44
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2025
@lentzi90
Copy link
Member Author

/cc @peppi-lotta
This should be useful when creating tests for the quick-start. We can embed whatever manifests we use for the tests directly in the guide. That way we always keep them in sync 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants