add a way to write python methods for rust-bound classes, round 2 #913
+120
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used to generate future python bindings for Context and Instance. The implementation documents how it works. This is the least bad way I could figure out how to do this since pyo3 does not natively let you subclass an existing python class. Differential Revision: [D80487153](https://our.internmc.facebook.com/intern/diff/D80487153/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Aug 18, 2025
This will be used to generate future python bindings for Context and Instance. The implementation documents how it works. This is the least bad way I could figure out how to do this since pyo3 does not natively let you subclass an existing python class. Differential Revision: [D80487153](https://our.internmc.facebook.com/intern/diff/D80487153/) ghstack-source-id: 303853759 Pull Request resolved: #913
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80487153 |
…round 2" This will be used to generate future python bindings for Context and Instance. The implementation documents how it works. This is the least bad way I could figure out how to do this since pyo3 does not natively let you subclass an existing python class. Differential Revision: [D80487153](https://our.internmc.facebook.com/intern/diff/D80487153/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Aug 18, 2025
Pull Request resolved: #913 This will be used to generate future python bindings for Context and Instance. The implementation documents how it works. This is the least bad way I could figure out how to do this since pyo3 does not natively let you subclass an existing python class. ghstack-source-id: 303855901 @exported-using-ghexport Differential Revision: [D80487153](https://our.internmc.facebook.com/intern/diff/D80487153/)
|
This pull request was exported from Phabricator. Differential Revision: D80487153 |
This was referenced Aug 19, 2025
…round 2" This will be used to generate future python bindings for Context and Instance. The implementation documents how it works. This is the least bad way I could figure out how to do this since pyo3 does not natively let you subclass an existing python class. Differential Revision: [D80487153](https://our.internmc.facebook.com/intern/diff/D80487153/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Aug 19, 2025
Pull Request resolved: #913 This will be used to generate future python bindings for Context and Instance. The implementation documents how it works. This is the least bad way I could figure out how to do this since pyo3 does not natively let you subclass an existing python class. ghstack-source-id: 304046443 @exported-using-ghexport Differential Revision: [D80487153](https://our.internmc.facebook.com/intern/diff/D80487153/)
|
This pull request was exported from Phabricator. Differential Revision: D80487153 |
|
This pull request has been merged in 4c2c4cb. |
This was referenced Aug 20, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This will be used to generate future python bindings for Context and Instance.
The implementation documents how it works.
This is the least bad way I could figure out how to do this since pyo3 does not natively let you subclass an existing python class.
Differential Revision: D80487153