Add simulator context manager and execution summary #908
+51
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80366675 |
…ns (#898) Summary: This diff: * exposes paft_manager.py's main so we can attach the simulator to it * Allows test_paft_manager.py to write log assertions using sqlite db * Add `is_simulator_active()` so we can decide whether to real/sim sleep in the actor Reviewed By: thomasywang Differential Revision: D80271648
Summary: To make the simulator a bit easier to use for monarch test workloads: * Add context manager to set up logging, tracing, sim event loop * print execution details after run including execution ID, scuba links to tracing/metrics table Reviewed By: eliothedeman Differential Revision: D80366675
facebook-github-bot
force-pushed
the
export-D80366675
branch
from
0e28325 to
fad2dd9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80366675 |
|
This pull request has been merged in fb24ab9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To make the simulator a bit easier to use for monarch test workloads:
Reviewed By: eliothedeman
Differential Revision: D80366675