Configurable debounce #854
Closed
+135
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80137965 |
thomasywang
force-pushed
the
export-D80137965
branch
from
f1c903d to
65b6fff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80137965 |
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 14, 2025
Summary: When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable. In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying Differential Revision: D80137965
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 14, 2025
Summary: When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable. In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying Differential Revision: D80137965
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 14, 2025
Summary: When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable. In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying Differential Revision: D80137965
thomasywang
force-pushed
the
export-D80137965
branch
from
65b6fff to
6a22895
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 14, 2025
Summary: When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable. In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying Differential Revision: D80137965
|
This pull request was exported from Phabricator. Differential Revision: D80137965 |
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 14, 2025
Summary: Pull Request resolved: meta-pytorch#854 When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable. In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying Differential Revision: D80137965
thomasywang
force-pushed
the
export-D80137965
branch
from
6a22895 to
5c83d94
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 18, 2025
Summary: When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable. In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying Reviewed By: pablorfb-meta Differential Revision: D80137965
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable. In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying Reviewed By: pablorfb-meta Differential Revision: D80137965
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable. In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying Reviewed By: pablorfb-meta Differential Revision: D80137965
thomasywang
force-pushed
the
export-D80137965
branch
from
5c83d94 to
cd696c3
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable. In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying Reviewed By: pablorfb-meta Differential Revision: D80137965
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: Pull Request resolved: meta-pytorch#854 When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable. In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying Differential Revision: D80137965 Reviewed By: pablorfb-meta
|
This pull request was exported from Phabricator. Differential Revision: D80137965 |
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 19, 2025
Summary: Pull Request resolved: meta-pytorch#854 When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable. In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying Reviewed By: pablorfb-meta Differential Revision: D80137965
thomasywang
force-pushed
the
export-D80137965
branch
from
cd696c3 to
5196164
Compare
Summary: Previously we had to use u64 for serialization reasons but those reasons no longer exist Differential Revision: D80556690
Summary: There was an open TODO to remove the global mailbox for SimClock. We don't actually even need mailboxes for sim clock and a oneshot works just fine Differential Revision: D80029571
thomasywang
force-pushed
the
export-D80137965
branch
from
5196164 to
db6f377
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 20, 2025
Summary: When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable. In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying Reviewed By: pablorfb-meta Differential Revision: D80137965
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 20, 2025
Summary: When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable. In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying Reviewed By: pablorfb-meta Differential Revision: D80137965
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 20, 2025
Summary: When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable. In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying Reviewed By: pablorfb-meta Differential Revision: D80137965
Summary: Pull Request resolved: meta-pytorch#854 When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable. In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying Reviewed By: pablorfb-meta Differential Revision: D80137965
|
This pull request was exported from Phabricator. Differential Revision: D80137965 |
thomasywang
force-pushed
the
export-D80137965
branch
from
db6f377 to
f6d3a18
Compare
thomasywang
added a commit
to thomasywang/monarch-1
that referenced
this pull request
Aug 20, 2025
Summary: Pull Request resolved: meta-pytorch#854 When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable. In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying Differential Revision: D80137965 Reviewed By: pablorfb-meta
|
This pull request has been merged in cf4110e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When we increase the number of actors in our simulation it takes longer for all the events at a certain time to complete so we need to wait for longer. If we wait to long then the simulation just runs slower than it needs to so its nice to make this configurable.
In the long term we will come up with a more robust solution to this but in the meantime that is not a priority. See EX528476 to understand the underlying problem the debounce is remedying
Differential Revision: D80137965