Skip to content

Allow periods in job names #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2015
Merged

Allow periods in job names #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f7645f
Add support for periods in job names
carroux Aug 25, 2015
ad1a530
Add test to ensure job names with periods are accepted
carroux Aug 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/scala/org/apache/mesos/chronos/scheduler/jobs/JobUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import scala.collection.mutable.ListBuffer
*/
object JobUtils {

val jobNamePattern = """([\w\s#_-]+)""".r
val jobNamePattern = """([\w\s\.#_-]+)""".r
val stats = new mutable.HashMap[String, DescriptiveStatistics]()
val maxValues = 100
//The object mapper, which is, according to the docs, Threadsafe once configured.
Expand Down
6 changes: 6 additions & 0 deletions src/test/scala/org/apache/mesos/chronos/scheduler/jobs/JobUtilsSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,10 @@ class JobUtilsSpec extends SpecificationWithJUnit with Mockito {
scheduledJobWithArguments.command.toString must_== commandWithArguments
dependencyJobWithArguments.command.toString must_== commandWithArguments
}

"Accepts a job name with periods" in {
val jobName = "sample.name"

JobUtils.isValidJobName(jobName)
}
}