Skip to content

inih: update to r54 #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2022
Merged

inih: update to r54 #340

merged 1 commit into from
Mar 23, 2022

Conversation

@stephanlachnit
Copy link
Contributor

@stephanlachnit stephanlachnit commented Mar 21, 2022

@stephanlachnit
Copy link
Contributor Author

stephanlachnit commented Mar 21, 2022

Interesting, for some reason the Ubuntu CI builds openssl, Windows fails due to a rather odd linking error and MacOS fails from ERROR: test_releases (__main__.TestReleases) (step='check_meson_version', name='openssl'), which I suspect has nothing to do with inih.

@eli-schwartz
Copy link
Member

eli-schwartz commented Mar 21, 2022

Another PR was merged which breaks everything. We're waiting for the submitter to fix it!

@stephanlachnit
Copy link
Contributor Author

stephanlachnit commented Mar 21, 2022

Another PR was merged which breaks everything. We're waiting for the submitter to fix it!

Figured, just ping me when I should rebase :)

@eli-schwartz
Copy link
Member

eli-schwartz commented Mar 21, 2022

Alright, time to rebase. :)

@stephanlachnit
Copy link
Contributor Author

stephanlachnit commented Mar 22, 2022 •
edited
Loading

Rebased. The VSC linking error still persists though...

[1/5] Compiling C object subprojects/inih-r53/inih-0.dll.p/ini.c.obj
[2/5] Linking target subprojects/inih-r53/inih-0.dll
[3/5] Generating symbol file subprojects/inih-r53/inih-0.dll.p/inih-0.dll.symbols
[4/5] Compiling C++ object subprojects/inih-r53/INIReader-0.dll.p/cpp_INIReader.cpp.obj
[5/5] Linking target subprojects/inih-r53/INIReader-0.dll
FAILED: subprojects/inih-r53/INIReader-0.dll subprojects/inih-r53/INIReader-0.pdb 
"link"  /MACHINE:x64 /OUT:subprojects/inih-r53/INIReader-0.dll subprojects/inih-r53/INIReader-0.dll.p/cpp_INIReader.cpp.obj "/nologo" "/release" "/nologo" "/DEBUG" "/PDB:subprojects\inih-r53\INIReader-0.pdb" "/DLL" "/IMPLIB:subprojects\inih-r53\INIReader.lib" "subprojects\inih-r53\inih.lib" "kernel32.lib" "user32.lib" "gdi32.lib" "winspool.lib" "shell32.lib" "ole32.lib" "oleaut32.lib" "uuid.lib" "comdlg32.lib" "advapi32.lib"
LINK : fatal error LNK1181: cannot open input file 'subprojects\inih-r53\inih.lib'

I guess this had to be the case before, I just don't quite get what the problem of the linker is. I don't see an issue in the meson.build wrt linking: https://github.com/benhoyt/inih/blob/r53/meson.build

I have no Windows experience, but I think subprojects\inih-r53\inih.lib should probably be subprojects/inih-r53/inih-0.dll or something - seems link a Meson/VSC bug to me?

Anyway, I think this should still be merged.

@eli-schwartz
Copy link
Member

eli-schwartz commented Mar 22, 2022

https://mesonbuild.com/FAQ.html#my-project-works-fine-on-linux-and-mingw-but-fails-to-link-with-msvc-due-to-a-missing-lib-file-fatal-error-lnk1181-why

It's a project definition bug.

Tachi107 added a commit to Tachi107/inih that referenced this pull request Mar 22, 2022
@Tachi107
Add visibility symbols
b5d5222 
They are required to properly build DLLs on Windows, and improve the
quality of shared objects on Linux.
See https://gcc.gnu.org/wiki/Visibility for details.

This issue was first discovered here:
mesonbuild/wrapdb#340 (comment)
Tachi107 added a commit to Tachi107/inih that referenced this pull request Mar 22, 2022
@Tachi107
Add visibility symbols
86ce837 
They are required to properly build DLLs on Windows, and improve the
quality of shared objects on Linux.
See https://gcc.gnu.org/wiki/Visibility for details.

This issue was first discovered here:
mesonbuild/wrapdb#340 (comment)
Tachi107 added a commit to Tachi107/inih that referenced this pull request Mar 22, 2022
@Tachi107
Add visibility symbols
8aaa3de 
They are required to properly build DLLs on Windows, and improve the
quality of shared objects on Linux.
See https://gcc.gnu.org/wiki/Visibility for details.

This issue was first discovered here:
mesonbuild/wrapdb#340 (comment)
Tachi107 added a commit to Tachi107/inih that referenced this pull request Mar 22, 2022
@Tachi107
Add visibility symbols
178e3fa 
They are required to properly build DLLs on Windows, and improve the
quality of shared objects on Linux.
See https://gcc.gnu.org/wiki/Visibility for details.

This issue was first discovered here:
mesonbuild/wrapdb#340 (comment)
@Tachi107 Tachi107 mentioned this pull request Mar 22, 2022
Merged
Tachi107 added a commit to Tachi107/inih that referenced this pull request Mar 22, 2022
@Tachi107
Add visibility symbols
61b20a1 
They are required to properly build DLLs on Windows, and improve the
quality of shared objects on Linux.
See https://gcc.gnu.org/wiki/Visibility for details.

This issue was first discovered here:
mesonbuild/wrapdb#340 (comment)
@stephanlachnit
Copy link
Contributor Author

stephanlachnit commented Mar 23, 2022

Thanks, learned yet something again.

Can we still merge this anyway for r53? Since a half working version is still better than a non-working version.

@eli-schwartz
Copy link
Member

eli-schwartz commented Mar 23, 2022

I would prefer to just ask for an r54 release. :)

benhoyt pushed a commit to benhoyt/inih that referenced this pull request Mar 23, 2022
@Tachi107
Add visibility symbols (#134)
5a31af9 
They are required to properly build DLLs on Windows, and improve the
quality of shared objects on Linux.
See https://gcc.gnu.org/wiki/Visibility for details.

This issue was first discovered here:
mesonbuild/wrapdb#340 (comment)
@stephanlachnit stephanlachnit changed the title inih: Fix INIReader_dep to upper case inih: update to r54 Mar 23, 2022
@stephanlachnit
Copy link
Contributor Author

stephanlachnit commented Mar 23, 2022

Alright, I changed this PR to r54 instead now.

@stephanlachnit
inih: update to r54
fd12870 
Fixes a bug reported here: Tachi107/cloudflare-ddns#10 (comment)

Signed-off-by: Stephan Lachnit <[email protected]>
@eli-schwartz
Copy link
Member

eli-schwartz commented Mar 23, 2022

Thanks!

@eli-schwartz eli-schwartz merged commit 0477552 into mesonbuild:master Mar 23, 2022
@Tachi107
Copy link
Contributor

Tachi107 commented Mar 23, 2022

Thanks everyone for the help :)

Tachi107 added a commit to Tachi107/cloudflare-ddns that referenced this pull request Mar 23, 2022
@Tachi107
build: update inih wrap to r54
919e1b0 
See mesonbuild/wrapdb#340
@stephanlachnit stephanlachnit deleted the p/inih-inireader-fix branch March 24, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephanlachnit @eli-schwartz @Tachi107