Skip to content

Error handling for empty chart url and package not found #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Error handling for empty chart url and package not found #526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb98868
fix: bug with variables passed wrongly w/signoff
Jougan-0 Jul 1, 2024
4b74e9f
Merge branch 'meshery:master' into errorHandlingForEmptyChartUrlAndPa…
Jougan-0 Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generators/artifacthub/package.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func (pkg AhPackage) GenerateComponents() ([]v1beta1.ComponentDefinition, error)
// TODO: Move this to the configuration

if pkg.ChartUrl == "" {
return components, ErrChartUrlEmpty("Artifacthub", pkg.Name)
return components, ErrChartUrlEmpty(pkg.Name, "ArtifactHub")
}
crds, err := manifests.GetCrdsFromHelm(pkg.ChartUrl)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion generators/artifacthub/package_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ func (ahpm ArtifactHubPackageManager) GetPackage() (models.Package, error) {
return nil, err
}
if len(pkgs) == 0 {
return nil, ErrNoPackageFound("Artifacthub", ahpm.PackageName)
return nil, ErrNoPackageFound(ahpm.PackageName, "Artifacthub")
}
// update package information
for i, ap := range pkgs {
Expand Down