-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Fixed edge animation for hand drawn shapes #6843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Fixed edge animation for hand drawn shapes #6843
Conversation
🦋 Changeset detectedLatest commit: bbb93b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6843 +/- ##
==========================================
- Coverage 3.56% 3.56% -0.01%
==========================================
Files 473 473
Lines 47198 47207 +9
Branches 728 728
==========================================
Hits 1684 1684
- Misses 45514 45523 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look great, just need a minor tweak on the class handling part to improve code quality.
packages/mermaid/src/rendering-util/rendering-elements/edges.js
Outdated
Show resolved
Hide resolved
packages/mermaid/src/rendering-util/rendering-elements/edges.js
Outdated
Show resolved
Hide resolved
…fix-edge-animation-for-hand-dranw-shapes
📑 Summary
Resolves #
📏 Design Decisions
edge-animation-*
class was not getting applied.edge-animation-*
class in hand drawn look.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.