-
-
Notifications
You must be signed in to change notification settings - Fork 8k
6784: Fix edge ID styling mismatch with linkStyle color #6826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6826 +/- ##
=======================================
Coverage 3.66% 3.66%
=======================================
Files 455 454 -1
Lines 45599 45594 -5
Branches 709 709
=======================================
Hits 1669 1669
+ Misses 43930 43925 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
on-behalf-of: @Mermaid-Chart <[email protected]>
🦋 Changeset detectedLatest commit: 2e1d156 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change breaks the Argos tests, specifically when styling using position number.
Some optional description over here if you need to add more info on-behalf-of: @Mermaid-Chart <[email protected]>
resolved in 227cef0 |
…6784-edge-label-color-mismatch
on-behalf-of: @Mermaid-Chart <[email protected]>
The following issue(s) were detected: Please address these and push an update. Posted automatically by GitHub Actions |
Some optional description over here if you need to add more info on-behalf-of: @Mermaid-Chart <[email protected]>
The following issue(s) were detected: Please address these and push an update. Posted automatically by GitHub Actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the pnpm-lock changes in this PR, and tests needs to pass.
Code changes looks good, but need to see argos test before approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
📑 Summary
This PR updates the edge rendering logic to ensure that when a class with a colour property is applied to an edge via its ID, the colour is also correctly applied to the edge label text—just like when using linkStyle.
Resolves #6784
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.