Skip to content

Conversation

rct
Copy link
Contributor

@rct rct commented Aug 19, 2022

Sanity checks to reduce false positives and other bad data from Ambient Weather F007TH and related thermo-hygrometers.

Packets with Bad data often pass the MIC check.

  • humidity > 100 (such as 255) and
  • temperatures > 140 F (such as 369.5 F (raw 0xFFF) and 348.8 F)

Specs in the F007TH and F012TH manuals state the range is:

  • Temperature: -40 to 140 F
  • Humidity: 10 to 99%

Note: Allowing humidity 0 and above because broken humidity sensors may report 1% or 0% but still have functional temperature sensors.

@rct
Copy link
Contributor Author

rct commented Aug 20, 2022

@zuckschwerdt - I may not have had enough coffee yet, but I'm not sure what to do about these symbol errors from these the symbol error check. It is building fine on my system.

Error: No func
Error: models not found (ambient_weather.c)
Error: but @sa (ambient_weather_decode)

@zuckschwerdt
Copy link
Collaborator

The checker is not really context sensitive and get's confused with the doc-comment at line 69. That should be /* not /**.
Also ideally the first line in the decoder doc-comment should be just a headline style sentence, mostly the same as line 2.
And lists (29 to 36) should not be indented but each line start with a dash.

@rct
Copy link
Contributor Author

rct commented Aug 22, 2022

Thanks, changes to the comments made the symbol checker happy.

Also, while testing and looking for bad data I noticed I get a lot of false positives from Oregon SL109H that all have humidity > 100.

@rct
Copy link
Contributor Author

rct commented Aug 30, 2022

@zuckschwerdt - do you need anything else from me on this?

@zuckschwerdt zuckschwerdt merged commit 44d5b00 into merbanan:master Aug 30, 2022
@rct rct deleted the aw-temphum-sanity-check branch September 2, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants