Fix: buffer length error in devices/honeywell.c #1598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuckschwerdt
reviewed
Jan 5, 2021
src/devices/honeywell.c
Outdated
| @@ -81,7 +81,7 @@ static int honeywell_decode(r_device *decoder, bitbuffer_t *bitbuffer) | |||
|
|
|||
| if (len > 50) { // DW11 | |||
| if (decoder->verbose) | |||
| bitrow_printf(b, len, "%s: ", __func__); | |||
| bitrow_printf(b, (len >80 ? 80 : len) , "%s: ", __func__); | |||
There was a problem hiding this comment.
A space after the comparison operator, please ;)
evilpete
force-pushed
the
honeywell-buff
branch
from
080a78c to
f9ea567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitrow_printf can be called with a length that exceeds the buffer length of
b(80 bits) if called with sufficiently large bitbuffercloses #1597