Added the capability to make filters exclusive #40
Conversation
reinouts
left a comment
reinouts
left a comment
There was a problem hiding this comment.
Could you provide feedback to my comments?
| } | ||
|
|
||
| //only one value is defined to filter? Then the other is always true | ||
| // if (this.falseitem ^ this.trueitem){ |
| for (var i = 0; i < this.menuItems.length; i++) { | ||
| var item = this.menuItems[i]; | ||
|
|
||
| if (item.label == label) { |
There was a problem hiding this comment.
A bit verbose?
item.set("checked", (item.label == label)) is more concise and would still be readable IMHO.
| "use strict"; | ||
|
|
||
| return declare("TreeView.widget.Filters.AbstractFilter", null, { | ||
| fm: null, |
| dropDown : this.menu | ||
| }); | ||
|
|
||
| if (this.filteranycaption) |
| dojo.place(this.dropdown.domNode, this.fm.domNode); | ||
| }, | ||
|
|
||
| getSearchConstraints: function () { |
There was a problem hiding this comment.
You already extend AbstractFilter right? Shouldn't this function with default implementation be already there?
|
|
||
| }, | ||
|
|
||
| free: function () { |
| }, | ||
|
|
||
| getSearchConstraints : function() { | ||
| // var filters = (!this.filtersexclusive) ? this.filter.getFilters() : []; |
src/TreeView/widget/ui/Filters.css
Outdated
|
|
||
|
|
||
| .gv_filter_dropdown_menu .dijitChecked::before { | ||
| content: √; |
There was a problem hiding this comment.
Disagree. This can be changed in a theme if someone wants to use something else. Plus, adding a symbol to ::before is not quite stable in Javascript.
There was a problem hiding this comment.
Actually, this css file does not even affect current rendering of the widget, so maybe I should actually delete it entirely. The final styling should be defined in the theme.
3 participants
No description provided.