Target ruby 3 with rubocop #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
=======================================
Coverage 88.90% 88.90%
=======================================
Files 13 13
Lines 757 757
=======================================
Hits 673 673
Misses 84 84 ☔ View full report in Codecov by Sentry. |
brunoocasali
previously approved these changes
Aug 7, 2024
|
@ellnix sorry can you fix the git conflicts? 🙈 |
curquiza
added
the
maintenance
This seems to have been missed when updating requirements from ruby 2.6 to 3.
ellnix
force-pushed
the
target-ruby-3-with-rubocop
branch
from
f26a8c9 to
451f931
Compare
Apologies for ghosting for so long, fixed the conflict (it was an edit to a file that has since been deleted) |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop's config was still enforcing ruby 2 code style. This is just a step that was missing in #367.