-
-
Notifications
You must be signed in to change notification settings - Fork 140
Adjust queue workers #933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Adjust queue workers #933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move thumbnail download from NET to FS. It does use the network, but not with `yt_dlp` and not in a way that YouTube cares about.
The parser change and a few other things mean that compatibility with `3.8` is unlikely to last much longer.
Merged
Closed
The `sqlite` driver appears to be fundamentally incompatible with the Django query set `iterator` function. It only works for the first chunk, then it fails any further database operations because the database is already locked.
@tcely This has conflicts. Thanks! |
@meeb The merge conflicts have been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The accumulation of memory can be mitigated by ending the queue workers periodically.
s6-supervise
is expected to launch a new process afterwards.Adding an offset to the sleep should help with
SQLite
concurrency issues. By starting tasks at different times, the chances of finding the database is locked should be reduced.Change the settings for
background_task
workers without additional user intervention.Fixes #428
Fixes #927
Fixes #955