Simplify directory_path #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looked to be identical code to what `filename` used. Remove the duplicated code by using the function instead.
|
Yep! There's a load of duplication in some areas. Also the models being a couple of massive classes is pretty messy. Throwbacks to when tubesync was some hacky nonsense before I released it. |
tcely
referenced
this pull request
in tcely/tubesync
Dec 11, 2024
Merge pull request #579 from tcely/patch-4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looked to be identical code to what
filenameused. Remove the duplicated code by using the function instead.