Skip to content

Conversation

tcely
Copy link
Contributor

@tcely tcely commented Dec 5, 2024

The function should return 'VP9' for:

  • vp9.1.2.3
  • vp09.4.5.6

As well as other variations.
It also works for avc01 or av01, or any others that fit the pattern.

The function should return 'VP9' for:

- vp9.1.2.3
- vp09.4.5.6

As well as other variations.
It also works for avc01 or av01, or any others that fit the pattern.
@tcely
Copy link
Contributor Author

tcely commented Dec 9, 2024

I've been running with this code for a while now. I'm seeing more exact matches than before.

@meeb
Copy link
Owner

meeb commented Dec 10, 2024

This looks fine, but preferably could do with some tests for the new function.

Edit: and thanks for the further contributions!

@tcely
Copy link
Contributor Author

tcely commented Dec 10, 2024

The matching tests are already exercising that function.
I checked the test data. I believe the coverage of the function is even complete.

Was there anything specific you were wanting to test?

@meeb
Copy link
Owner

meeb commented Dec 10, 2024

Ah, I just meant as you're (slightly) modifying how the codec string was being parsed if there was a test that explicitly confirmed this behavior. Current tests are probably sufficient.

@meeb meeb merged commit 7974819 into meeb:main Dec 10, 2024
@tcely
Copy link
Contributor Author

tcely commented Dec 10, 2024

I'm up for adding more tests, especially as the boring metadata doesn't have any vcodec matching this vp09.01.2.40 pattern, that I saw in my database.

The 20230629 metadata does have both vp09 and av01 codecs though.

@tcely tcely deleted the patch-3 branch December 10, 2024 08:02
@meeb
Copy link
Owner

meeb commented Dec 10, 2024

Yeah YouTube especially seem to tweak the codecs quite frequently. The version number postfixes are a new-ish change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants