-
-
Notifications
You must be signed in to change notification settings - Fork 140
Refinements for Dockerfile #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Specifically turn off flags to printf where none are intended. There are fewer things to keep in mind this way.
Nothing later should have been affected, but this is the cleaner way.
This should be enough to fail the build when the binary doesn't work.
The shell used on the build system doesn't support `pipefail` so test for output instead. It might be incorrect output, but in combination with running the `ffmpeg` binary earlier, this should be enough.
It turned out `exit` doesn't work as I thought it did.
What build system are you using? I don't particularly mind merging these after looking at them, but a lot of them seem to be accounting for what look like largely impossible failures or dumping info that's likely not too useful. Is there some use case for all of this? |
Actually, the inspiration was from seeing the logs from the GitHub workflow. I was surprised that the The change of the scope for when The |
Far enough, no real objections to your adjustments, I'll merge them into the next release. Edit: and thanks for the efforts! |
Thank you for your great software and prompt reviews! |
The most important is catching when the
s6
orffmpeg
binaries aren't actually working correctly.