Skip to content

Enforce unique for TaskHistory.task_id #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2025
Merged

Enforce unique for TaskHistory.task_id #1221

merged 2 commits into from
Jul 16, 2025

Conversation

tcely
Copy link
Contributor

@tcely tcely commented Jul 15, 2025

Fixes #1220

@tcely tcely marked this pull request as ready for review July 15, 2025 21:47
@tcely tcely moved this to In Progress in Status Jul 15, 2025
@tcely tcely moved this from In Progress to Ready in Status Jul 15, 2025
@meeb meeb merged commit fdbd15b into meeb:main Jul 16, 2025
9 checks passed
@meeb
Copy link
Owner

meeb commented Jul 16, 2025 •
edited
Loading

This will break for the person who opened #1220 though probably!

@github-project-automation github-project-automation bot moved this from Ready to Done in Status Jul 16, 2025
@tcely tcely deleted the patch-7 branch July 16, 2025 15:50
@tcely
Copy link
Contributor Author

tcely commented Jul 17, 2025

You were correct. There are going to be duplicated rows for more people than I first thought.

I likely should have enforced this constraint from the beginning.

#1225 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Status
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: get() returned more than one TaskHistory -- it returned 2
2 participants
@tcely @meeb