Skip to content

Conversation

tcely
Copy link
Contributor

@tcely tcely commented Jun 19, 2025

I haven't given this change great consideration.
If there is a reason not to allow Unicode, then please let me know.

@meeb Why are underscores disallowed?

Fixes #527

@tcely tcely marked this pull request as ready for review June 19, 2025 13:47
@tcely tcely moved this to Ready in Status Jun 19, 2025
@meeb
Copy link
Owner

meeb commented Jun 19, 2025

Only reason underscores were disallowed in titles was to make the default media template slightly easier to parse as it was originally date_channel_sluggified-title.ext. Allowing underscores in the sluggified title made it slightly messier. This is back from the days when this was just my personal downloading tool. I'm fine with allowing underscores if there's a request for it.

The Unicode issue was for people storing media on some network shares (and possibly Windows?) which caused the file names to either error when writing certain characters or write files with the ever popular black squares all over the file name. This again was from a few years ago and might not be an issue now.

Edit: I thought Unicode was already allowed, obviously just implemented badly so there were some problems as described in the linked issue.

@tcely
Copy link
Contributor Author

tcely commented Jun 19, 2025

I'm fine with allowing underscores if there's a request for it.

Ok. I'll request and implement that change then.

@meeb meeb merged commit f17af83 into meeb:main Jun 19, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Done in Status Jun 19, 2025
@tcely tcely deleted the patch-11 branch June 19, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

{Title} fails for unicode characters
2 participants