-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
docs: fix filters in meilisearch and algolia guides #14098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
6 Skipped Deployments
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| status: ProductStatus.PUBLISHED, | ||
| ...data.filters | ||
| } | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Filters can override published status requirement
The transform callback merges filters in an incorrect order. When ...data.filters is spread after setting status: ProductStatus.PUBLISHED, any incoming filters with a status property will override the required published status. This defeats the PR's goal of ensuring only published products sync. The spread operator should come first so the published status assignment overrides incoming filters.
Summary
What — What changes are introduced in this PR?
Closes #13816
Why — Why are these changes relevant or necessary?
Please provide answer here
How — How have these changes been implemented?
Please provide answer here
Testing — How have these changes been tested, or how can the reviewer test the feature?
Please provide answer here
Examples
Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.
// Example usageChecklist
Please ensure the following before requesting a review:
yarn changesetand follow the promptsAdditional Context
Add any additional context, related issues, or references that might help the reviewer understand this PR.
Note
Updates Algolia and Meilisearch guides to only sync published products and refreshes related docs/prerequisites.
transformandProductStatus.PUBLISHEDto buildproductqueryfilters; replace inline{ status: "published", ... }withproductFiltersinuseQueryGraphStep.status: "published"tofilterswhen syncing a single product onproduct.created/product.updated.app/integrations/guides/algoliaand.../meilisearch.Written by Cursor Bugbot for commit e4932f6. This will update automatically on new commits. Configure here.