Skip to content

Conversation

@shahednasser
Copy link
Member

@shahednasser shahednasser commented Nov 20, 2025

Summary

What — What changes are introduced in this PR?

  • Fix filters applied in the syncing workflows in Meilisearch and Algolia
  • Apply filter on product creation and update event to ensure only published products are synced.

Closes #13816

Why — Why are these changes relevant or necessary?

Please provide answer here

How — How have these changes been implemented?

Please provide answer here

Testing — How have these changes been tested, or how can the reviewer test the feature?

Please provide answer here


Examples

Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.

// Example usage

Checklist

Please ensure the following before requesting a review:

  • I have added a changeset for this PR
    • Every non-breaking change should be marked as a patch
    • To add a changeset, run yarn changeset and follow the prompts
  • The changes are covered by relevant tests
  • I have verified the code works as intended locally
  • I have linked the related issue(s) if applicable

Additional Context

Add any additional context, related issues, or references that might help the reviewer understand this PR.


Note

Updates Algolia and Meilisearch guides to only sync published products and refreshes related docs/prerequisites.

  • Integrations Guides (Algolia & Meilisearch)
    • Workflows: Use transform and ProductStatus.PUBLISHED to build product query filters; replace inline { status: "published", ... } with productFilters in useQueryGraphStep.
    • Event Subscribers: Add status: "published" to filters when syncing a single product on product.created/product.updated.
  • Docs Updates
    • Caching Module: Add Cloud setup link and a Redis prerequisite; clarify that the module is installed by default and must be enabled/registered.
    • Prerequisites: Tweak Node.js requirement to "v20+ (LTS versions)".
    • Meta: Update edit timestamps for app/integrations/guides/algolia and .../meilisearch.

Written by Cursor Bugbot for commit e4932f6. This will update automatically on new commits. Configure here.

@shahednasser shahednasser requested a review from a team as a code owner November 20, 2025 15:24
@vercel
Copy link

vercel bot commented Nov 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Nov 20, 2025 3:29pm
resources-docs Ready Ready Preview Comment Nov 20, 2025 3:29pm
6 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
api-reference Ignored Ignored Nov 20, 2025 3:29pm
api-reference-v2 Ignored Ignored Nov 20, 2025 3:29pm
cloud-docs Ignored Ignored Nov 20, 2025 3:29pm
docs-ui Ignored Ignored Nov 20, 2025 3:29pm
medusa-docs Ignored Ignored Nov 20, 2025 3:29pm
user-guide Ignored Ignored Nov 20, 2025 3:29pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025

⚠️ No Changeset found

Latest commit: e4932f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

status: ProductStatus.PUBLISHED,
...data.filters
}
})
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Filters can override published status requirement

The transform callback merges filters in an incorrect order. When ...data.filters is spread after setting status: ProductStatus.PUBLISHED, any incoming filters with a status property will override the required published status. This defeats the PR's goal of ensuring only published products sync. The spread operator should come first so the published status assignment overrides incoming filters.

Fix in Cursor Fix in Web

@shahednasser shahednasser merged commit b3f4ddc into develop Nov 24, 2025
41 of 47 checks passed
@shahednasser shahednasser deleted the docs/search-fix branch November 24, 2025 06:53
Balu-Varanasi pushed a commit to Balu-Varanasi/medusa that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter by status doesn't work

2 participants