chore(workflows-sdk, utils): Prevent unnecessary serialization #13413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
7 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 752c278 The changes in this PR will be included in the next version bump. This PR includes changesets to release 71 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
adrien2p
commented
Sep 4, 2025
| * @returns | ||
| */ | ||
| export function parseStringifyIfNecessary(result: unknown) { | ||
| if (typeof result !== "object") { |
There was a problem hiding this comment.
self-review: I purpusfully do not use isObject because I want to include Map, Set, Date etc
olivermrbl
approved these changes
Sep 4, 2025
This was referenced Sep 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RESOLVES CORE-1154 (here some explanation why only doing that)
What
Workflow are heavely relying on the value resolution, which always parse/stringify data to prevent shared references. But in a lot of cases, these value can be primitive only and in that case there is no need to perform such action
It happen to be more than 3X faster to do nothing instead of extraneous operation plus it will have less impact on the memory and GC.