Skip to content

chore(framework,medusa): load custom flags before medusa config #13312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Sep 1, 2025
Merged

chore(framework,medusa): load custom flags before medusa config #13312

merged 19 commits into from
Sep 1, 2025

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

What:

  • Loads custom feature flags from a Medusa project before the medusa-config itself. That makes the flags available into medusa-config.ts file and all other resources

@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner August 27, 2025 16:07
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 0770fb1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 71 packages
Name Type
@medusajs/framework Patch
@medusajs/medusa Patch
@medusajs/test-utils Patch
@medusajs/modules-sdk Patch
@medusajs/utils Patch
@medusajs/analytics Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/settings Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/analytics-local Patch
@medusajs/analytics-posthog Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/draft-order Patch
@medusajs/core-flows Patch
@medusajs/medusa-oas-cli Patch
integration-tests-http Patch
@medusajs/workflows-sdk Patch
@medusajs/orchestration Patch
@medusajs/cli Patch
@medusajs/oas-github-ci Patch
@medusajs/js-sdk Patch
@medusajs/types Patch
@medusajs/telemetry Patch
@medusajs/admin-bundler Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/dashboard Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch
@medusajs/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Aug 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
medusa-dashboard Ready Ready Preview Comment Sep 1, 2025 1:24pm
8 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
api-reference Ignored Ignored Sep 1, 2025 1:24pm
api-reference-v2 Ignored Ignored Preview Sep 1, 2025 1:24pm
cloud-docs Ignored Ignored Preview Sep 1, 2025 1:24pm
docs-ui Ignored Ignored Preview Sep 1, 2025 1:24pm
docs-v2 Ignored Ignored Preview Sep 1, 2025 1:24pm
medusa-docs Ignored Ignored Preview Sep 1, 2025 1:24pm
resources-docs Ignored Ignored Preview Sep 1, 2025 1:24pm
user-guide Ignored Ignored Preview Sep 1, 2025 1:24pm

adrien2p
adrien2p approved these changes Aug 27, 2025
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🎉

@adrien2p
Copy link
Member

shall we catch that in the integration tests?

adrien2p
adrien2p approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there a need to change anything around the test runners?

@carlos-r-l-rodrigues
Copy link
Contributor Author

LGTM, is there a need to change anything around the test runners?

Yes, we have to load the flags before initializing the test, otherwise it will require the medusa-config file before the flags are loaded and it will cause issues if there is any FeatureFlag usage in it.

@adrien2p
Copy link
Member

LGTM, is there a need to change anything around the test runners?

Yes, we have to load the flags before initializing the test, otherwise it will require the medusa-config file before the flags are loaded and it will cause issues if there is any FeatureFlag usage in it.

Perfect, just missed the file and thought it was missing 👌

@kodiakhq kodiakhq bot removed the automerge label Aug 28, 2025
@kodiakhq kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 28, 2025

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@medusajs medusajs deleted a comment from github-actions bot Aug 28, 2025
@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner August 28, 2025 14:49
@medusajs medusajs deleted a comment from github-actions bot Sep 1, 2025
@carlos-r-l-rodrigues
Copy link
Contributor Author

/snapshot-this

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add [email protected]
yarn add @medusajs/[email protected]
yarn add [email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: 2a94dbd

@olivermrbl olivermrbl merged commit b4c0f13 into develop Sep 1, 2025
30 of 37 checks passed
@olivermrbl olivermrbl deleted the chore/custom-flags-before-config branch September 1, 2025 14:04
This was referenced Sep 1, 2025
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl left review comments

@adrien2p adrien2p adrien2p approved these changes

Assignees
No one assigned
Labels
team: medusa type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlos-r-l-rodrigues @adrien2p @olivermrbl