fix(pricing): fix pricing query when max_quantity is null #12981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 5f69f8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 69 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
olivermrbl
approved these changes
Jul 20, 2025
.../modules/pricing/integration-tests/__tests__/services/pricing-module/calculate-price.spec.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+499
to
+512
| calculated_price: { | ||
| id: "price-PLN-min-quantity-only", | ||
| price_list_id: null, | ||
| price_list_type: null, | ||
| min_quantity: 20, | ||
| max_quantity: null, | ||
| }, | ||
| original_price: { | ||
| id: "price-PLN-min-quantity-only", | ||
| price_list_id: null, | ||
| price_list_type: null, | ||
| min_quantity: 20, | ||
| max_quantity: null, | ||
| }, |
There was a problem hiding this comment.
thought(non-blocking): Should these not contain an amount by default? Without it, they are of no good use.
…pricing-module/calculate-price.spec.ts
This was referenced Jul 20, 2025
This was referenced Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what:
Prices when max_quantity value is null is accounted for when quantity is passed in context.