-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix(link-modules,core-flows): Carry over cart promotions to order promotions #12920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Skipped Deployments
|
🦋 Changeset detectedLatest commit: ccf89f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 69 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -44,8 +44,8 @@ export const OrderPromotion: ModuleJoinerConfig = { | |||
serviceName: Modules.ORDER, | |||
entity: "Order", | |||
fieldAlias: { | |||
promotion: { | |||
path: "promotion_link.promotion", | |||
promotions: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: this is a breaking change; should we keep + deprecate the old alias for now, and remove it later? would like to avoid having to cut a minor for a small change like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what: