Skip to content

fix(core-flows): updating tax lines when draft order shipping is removed #12919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 14, 2025

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Jul 10, 2025

What

  • don't call updateOrderTaxLinesWorkflow when a shipping method is removed from a draft order (tax lines will be cascade deleted with the method)

Copy link

changeset-bot bot commented Jul 10, 2025

🦋 Changeset detected

Latest commit: 8042926

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 69 packages
Name Type
@medusajs/core-flows Patch
@medusajs/medusa Patch
integration-tests-http Patch
@medusajs/test-utils Patch
@medusajs/medusa-oas-cli Patch
@medusajs/analytics Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/oas-github-ci Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/analytics-local Patch
@medusajs/analytics-posthog Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/types Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/cli Patch
@medusajs/telemetry Patch
@medusajs/admin-bundler Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/dashboard Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch
@medusajs/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 1:51pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jul 14, 2025 1:51pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 14, 2025 1:51pm
cloud-docs ⬜️ Ignored (Inspect) Visit Preview Jul 14, 2025 1:51pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jul 14, 2025 1:51pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 14, 2025 1:51pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jul 14, 2025 1:51pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jul 14, 2025 1:51pm
user-guide ⬜️ Ignored (Inspect) Visit Preview Jul 14, 2025 1:51pm

@fPolic fPolic marked this pull request as ready for review July 10, 2025 11:00
@fPolic fPolic requested a review from a team as a code owner July 10, 2025 11:00
@fPolic fPolic requested review from riqwan, christiananese, olivermrbl and carlos-r-l-rodrigues and removed request for christiananese July 10, 2025 11:00
@kodiakhq kodiakhq bot merged commit a28226a into develop Jul 14, 2025
17 of 26 checks passed
@kodiakhq kodiakhq bot deleted the fix/do-rm-shipping-tax-lines branch July 14, 2025 13:35
scherddel pushed a commit to scherddel/medusa that referenced this pull request Jul 14, 2025
…ved (medusajs#12919)

**What**
- don't call `updateOrderTaxLinesWorkflow` when a shipping method is removed from a draft order (tax lines will be cascade deleted with the method)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants