fix(core-flows): missing variable of when condition #10958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-r-l-rodrigues
requested review from
sradevski,
kasperkristensen and
olivermrbl
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 2b8598b The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
adrien2p
approved these changes
Jan 14, 2025
| }).then(() => { | ||
| when( | ||
| { input, cartPaymentCollection }, | ||
| ({ input, cartPaymentCollection }) => { |
There was a problem hiding this comment.
It is also like that line 42, so probably it 👍
|
Im trying to build these changes on top of current medusa repo and build keeps failing, even after adding in multiple @ts-expect-error. Do you have the built files I can copy over to test in the dev instance i have stood up? Or can i just manually edit the .js file in node_modules/@medusajs/core-workflows? |
Yes, you can do that. This is the quickest way to test it. |
olivermrbl
approved these changes
Jan 14, 2025
this PR did not resolve my issue (#10949). nothing happens after webhook post.
|
This was referenced Jan 15, 2025
Closed
noubase
pushed a commit
to noubase/medusa
that referenced
this pull request
Jan 22, 2025
jimrarras
pushed a commit
to jimrarras/medusa
that referenced
this pull request
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We couldn't reproduce the issue #9998, but giving the stack trace, this is a potential fix.