Skip to content

fix: add reservations for current line item to available quantity #10801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: v1.x
Choose a base branch
from

Conversation

kevinfurmanski
Copy link
Contributor

When attempting to create a fulfillment with the last remaining item in stock, the reservation of the item blocks you from creating the fulfillment. This PR adds the quantity of any reservations for the specific line item and location to the available quantity for fulfillment.

Fixes #9821

@kevinfurmanski kevinfurmanski requested a review from a team as a code owner January 2, 2025 23:32
Copy link

changeset-bot bot commented Jan 2, 2025

⚠️ No Changeset found

Latest commit: e7a655e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 2, 2025

@kevinfurmanski is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@SalahAdDin
Copy link

When attempting to create a fulfillment with the last remaining item in stock, the reservation of the item blocks you from creating the fulfillment. This PR adds the quantity of any reservations for the specific line item and location to the available quantity for fulfillment.

Fixes #9821

Does it require to update the tests?

@kevinfurmanski
Copy link
Contributor Author

When attempting to create a fulfillment with the last remaining item in stock, the reservation of the item blocks you from creating the fulfillment. This PR adds the quantity of any reservations for the specific line item and location to the available quantity for fulfillment.
Fixes #9821

Does it require to update the tests?

I don' think so, it's a UI issue in admin

@kevinfurmanski kevinfurmanski force-pushed the fix/create-fulfillment-with-last-item branch from f357bc2 to d379aea Compare January 26, 2025 18:41
@kevinfurmanski
Copy link
Contributor Author

@olivermrbl Can we get this merged to the v1.x branch and make a new release? I currently need to run a custom script to mark orders as fulfilled since it's not possible to do through the admin UI 😅

@kevinfurmanski
Copy link
Contributor Author

@riqwan Thank you for approving my PR. Do you know how to get approval from medusajs/ui to be able to merge this commit?

@SalahAdDin
Copy link

@olivermrbl Can we get this merged to the v1.x branch and make a new release? I currently need to run a custom script to mark orders as fulfilled since it's not possible to do through the admin UI 😅

I would be required to create a PR for that version.

Copy link
Contributor

github-actions bot commented Mar 7, 2025

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added Stale and removed Stale labels Mar 7, 2025
Copy link
Contributor

github-actions bot commented Apr 7, 2025

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added Stale and removed Stale labels Apr 7, 2025
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 20, 2025
@SalahAdDin
Copy link

About to finish, we need a reviewer here.

@github-actions github-actions bot removed the Stale label May 28, 2025
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jun 30, 2025
@kevinfurmanski
Copy link
Contributor Author

@SalahAdDin @riqwan Can someone review this PR so it can finally be merged?

@SalahAdDin
Copy link

@riqwan can you check it, please?

@SalahAdDin
Copy link

Maybe a version for 2.x works as well.

@github-actions github-actions bot removed the Stale label Jul 5, 2025
Copy link
Contributor

github-actions bot commented Aug 5, 2025

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 5, 2025
@SalahAdDin
Copy link

@riqwan is there anyone planning to merge this?

@github-actions github-actions bot removed the Stale label Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants