Ensure tests close all opened applications and tabs #261
Conversation
Introduces CloseOnDrop struct to automatically close UIElement instances when they go out of scope, preventing resource leaks in tests. Co-authored-by: louis.beaumont <[email protected]>
|
Cursor Agent can help with this pull request. Just |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, please upgrade to Bugbot Pro by visiting the Cursor dashboard. Your first 14 days will be free!
|
|
||
| match engine.open_url(url, Some(browser.clone())) { | ||
| Ok(element) => { | ||
| let _guard = CloseOnDrop(&element); |
There was a problem hiding this comment.
Bug: CloseOnDrop Prematurely Closes Browser Windows
The CloseOnDrop guard in test_multiple_browser_windows and test_open_url_browser_detection closes browser windows immediately after opening them. This prevents these tests from correctly verifying scenarios that rely on windows remaining open for subsequent steps, like enumerating applications or counting multiple active browser instances.
Additional Locations (2)
Pull Request Template
Description
Ensures that tests reliably close any applications or browser tabs they open, even if the test fails or panics. This prevents resource leaks and improves test isolation by using RAII-style
CloseOnDropguards.Type of Change
Video Demo (Recommended)
🎥 Not applicable for this change, as it's an internal test infrastructure improvement.
AI Review & Code Quality
Checklist
Additional Notes
Implemented
CloseOnDropin:terminator/tests/click_timing_regression_test.rsterminator/tests/open_url.rsterminator/tests/open_url_unit_tests.rsThis is the first batch of changes; further updates to workflow-recorder tests and
e2e_tests.rsare planned.