Updating intrinsic sizing keywords data #3457
Conversation
Firefox 66 has unprefixed the min-content and max-content keywords. I'veupdated the compat data based on this and my testing. The fit-content keyword is still left prefixed. The data is pretty patchy so I also tested on some other browsers to fill out some nulls, so have updated Edge and Safari too.
ddbeck
added
the
data:css
|
Good catch, I must have missed those when trying to split the data in a sensible manner. Fixed. Also while just checking I hadn't been thinking of something else I got the Opera data so have included that, and done some other fixing up. |
There was a problem hiding this comment.
I think there's one last thing to fix here. Thank you, @rachelandrew!
| } | ||
| ], | ||
| "chrome_android": { | ||
| "version_added": "46" |
There was a problem hiding this comment.
This needs to match chrome.
css/properties/max-width.json
Outdated
| "version_added": "5.0" | ||
| }, | ||
| "webview_android": { | ||
| "version_added": "46" |
There was a problem hiding this comment.
"webview_android": [
{
"version_added": "46"
},
{
"prefix": "-webkit-",
"version_added": "true"
}
]
| } | ||
| ], | ||
| "chrome_android": { | ||
| "version_added": "46" |
There was a problem hiding this comment.
My earlier comment is an error. This should match chrome.
css/properties/min-width.json
Outdated
| "version_added": "5.0" | ||
| }, | ||
| "webview_android": { | ||
| "version_added": "46" |
There was a problem hiding this comment.
"webview_android": [
{
"version_added": "46"
},
{
"prefix": "-webkit-",
"version_added": "true"
}
]
| } | ||
| ], | ||
| "chrome_android": { | ||
| "version_added": "46" |
css/properties/min-width.json
Outdated
| }, | ||
| "webview_android": { | ||
| "version_added": null | ||
| "version_added": "46" |
There was a problem hiding this comment.
"webview_android": [
{
"version_added": "46"
},
{
"prefix": "-webkit-",
"version_added": "true"
}
]
| } | ||
| ], | ||
| "chrome_android": { | ||
| "version_added": "46" |
css/properties/min-width.json
Outdated
| "version_added": "5.0" | ||
| }, | ||
| "webview_android": { | ||
| "version_added": "46" |
There was a problem hiding this comment.
"webview_android": [
{
"version_added": "46"
},
{
"prefix": "-webkit-",
"version_added": "true"
}
]
|
I believe the changes have all been done although this has become an exercise in chasing my own tail as comments are being made while I'm trying to make updates on previous comments. I suggest that we merge this, and if there are still issues please raise them and I'll make a new PR to fix these. The aim of this was to support the Firefox release. |
3 participants
Firefox 66 has unprefixed the min-content and max-content keywords: https://bugzilla.mozilla.org/show_bug.cgi?id=1322780. I've updated the compat data based on this and my testing. The fit-content keyword is still left prefixed.
The data is pretty patchy so I also tested on some other browsers to fill out some nulls, so have updated Edge and Safari too.
All of the sizing keywords were combined in some files, and as data typically is different, I split these out. I added sections for these keywords where there were none.