-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Chrome 141 adds getDisplayMedia()
windowAudio
option
#28130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome 141 adds getDisplayMedia()
windowAudio
option
#28130
Conversation
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
@eladalon1983, could you have a look at this compat data PR and let me know if it agrees with your understanding? The data is a bit weird, but this is what my tests showed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure the default values are inversed between Chrome and Edge?
Your changes state:
- Chrome 141 =
system
, but Edge 141/142 =exclude
- Chrome 142+ =
exclude
, but Edge 143+ =system
api/MediaDevices.json
Outdated
"chrome": [ | ||
{ | ||
"version_added": "142", | ||
"partial_implementation": true, | ||
"notes": [ | ||
"Default value = `exclude`", | ||
"`window` value not supported" | ||
] | ||
}, | ||
{ | ||
"version_added": "141", | ||
"version_removed": "142", | ||
"partial_implementation": true, | ||
"notes": [ | ||
"Default value = `system`", | ||
"`window` value not supported" | ||
] | ||
} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge the partial statements:
"chrome": [ | |
{ | |
"version_added": "142", | |
"partial_implementation": true, | |
"notes": [ | |
"Default value = `exclude`", | |
"`window` value not supported" | |
] | |
}, | |
{ | |
"version_added": "141", | |
"version_removed": "142", | |
"partial_implementation": true, | |
"notes": [ | |
"Default value = `system`", | |
"`window` value not supported" | |
] | |
} | |
], | |
"chrome": { | |
"version_added": "141", | |
"partial_implementation": true, | |
"notes": [ | |
"Defaults to `\"exclude\". Before Chrome 142, it defaulted to `\"system\"`.", | |
"Only supports values `\"exclude\"` and `\"system\"`, not `\"window\"`." | |
] | |
}, |
getDisplayMedia()
windowAudio
option
I think @drkron should take it from here. :-) |
@caugner it sounds weird, but this is what I found during testing. I agree with merging the partials; I've implemented the updates locally and then pushed. |
Summary
Chrome/Edge desktop 141 add support for the
getDisplayMedia()
windowAudio
option. See https://chromestatus.com/feature/5072779506089984.This PR adds support for the new option. Note the slightly weird set of default values that differ across browsers and versions, and the partial implementation. I found these results by testing a modified version of https://mdn.github.io/dom-examples/screen-capture-api/basic-screen-capture/ with the new option added in.
Test results and supporting details
Related issues