Skip to content

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Oct 6, 2025

Summary

This PR addresses feedback provided about method support in sync storage in Firefox for Android by:

  • adding note to the methods under StorageArea.
  • adding impl_url and partial_implementation properties under sync.

In addition, the support for getBytesInUse under session storage was corrected to indicate the method is not supported (it's not supported anywhere within Firefox for Android.)

@rebloor rebloor requested review from Rob--W and dotproto October 6, 2025 17:50
@rebloor rebloor self-assigned this Oct 6, 2025
@rebloor rebloor added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Oct 6, 2025
@github-actions github-actions bot added the size:m [PR only] 25-100 LoC changed label Oct 6, 2025
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested to set getBytesInUse to mirror, but not everything is visible in the diff. Please fix it up across the whole storage.json file and I'll review again.

"notes": "Doesn't support the `managed` storage area."
"notes": [
"Doesn't support the `managed` storage area.",
"Data isn't synchronized with the user's Mozilla account and the storage quota limits are not enforced in the `sync` storage area. See [bug 1625257](https://bugzil.la/1625257)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quota enforcement is only relevant to the set method, not to the other methods. I'm not sure if we should event document the lack of quota enforcement, as it is not exactly an intended feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rob--W now only mentions the issue in relation to sync and set.

@rebloor rebloor requested a review from Rob--W October 14, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions size:m [PR only] 25-100 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants